chore: Support multiple supervisors: Decouple challengers from networks [4/N]#243
Merged
janjakubnanista merged 2 commits intomainfrom May 1, 2025
Merged
chore: Support multiple supervisors: Decouple challengers from networks [4/N]#243janjakubnanista merged 2 commits intomainfrom
janjakubnanista merged 2 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The challenger instances are decoupled from L2 networks and their configuration is moving to the top-level configuration.
Notes
There are several larger motions in this PR aimed at laying down the groundwork for further improvements:
dict, then reformatting it to astructhas been removed. As it is, it adds no value and only creates room for errorchallengers.default_paramsobject. Instead, YAML anchors can be utilised to share pieces of configuration. This removes the need for extra parsing logic and keeps things as lean as possibleservice_nameproperty. This will become important when it comes to resolving circular dependencies later on, as URLs will be possible to construct without having an instance ofServicemkdir &&combined withsh -centrypoint has been replaced (only forop-challenger) with a persistent directory.Questions
@sigma there will be more objects where something points to a list of networks. I named the field
participantsso that later on we might expand it to cover both networks and interop sets (with a heterogeneous list of some sort, TBD). That okay? I want to avoid confusion withparticipantsinchainsthat signify nodes rather than networks.Related to ethereum-optimism/optimism#15611